icon-project / icon-bridge

The centralized bridge of ICON
Apache License 2.0
21 stars 15 forks source link

fix(bmr): only forward events to the intended destination #29 #766

Closed bbist closed 1 year ago

bbist commented 1 year ago

Closes #ISSUE-NUMBER

Checklist:

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

codecov[bot] commented 1 year ago

Codecov Report

Merging #766 (dfa93ab) into main (3a158d6) will decrease coverage by 0.21%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #766      +/-   ##
============================================
- Coverage     38.07%   37.85%   -0.22%     
  Complexity      801      801              
============================================
  Files           115      115              
  Lines         11152    11152              
  Branches        941      941              
============================================
- Hits           4246     4222      -24     
- Misses         6585     6605      +20     
- Partials        321      325       +4     
Impacted Files Coverage Δ
cmd/iconbridge/chain/bsc/receiver.go 53.17% <0.00%> (-5.86%) :arrow_down:
cmd/iconbridge/chain/substrate-eth/receiver.go 0.00% <0.00%> (ø)
manishbista28 commented 1 year ago

Will case sensitivity of address be a problem in case of icon receiver.go ?

bbist commented 1 year ago

Will case sensitivity of address be a problem in case of icon receiver.go ?

Yeah. Case sensitivity is an issue. The assumption is that the BTP address string passed from the config file should be exactly the same as the value being used by the contract.