icon-project / icon-bridge

The centralized bridge of ICON
Apache License 2.0
21 stars 15 forks source link

fix(e2e): handle wrapped coin intra-chain transfer (#798) #799

Closed manishbista28 closed 1 year ago

manishbista28 commented 1 year ago

Closes #798

Checklist:

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

manishbista28 commented 1 year ago

@andrii-kl , could you please check if the changes in this branch work for your case ?

codecov[bot] commented 1 year ago

Codecov Report

Merging #799 (add1b79) into main (afb09c0) will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #799      +/-   ##
============================================
- Coverage     38.20%   38.15%   -0.05%     
  Complexity      801      801              
============================================
  Files           115      115              
  Lines         11161    11161              
  Branches        941      941              
============================================
- Hits           4264     4259       -5     
- Misses         6579     6584       +5     
  Partials        318      318              
Impacted Files Coverage Δ
cmd/iconbridge/chain/bsc/receiver.go 57.80% <0.00%> (-1.22%) :arrow_down:
andrii-kl commented 1 year ago

We have a lot of hardcoded values, it would be nice to refactoring it to get all these values from a config file.