search

icon-project / icon-bridge

The centralized bridge of ICON
Apache License 2.0
21 stars 15 forks source link

feat: Initial Algorand Structure #831

Closed pedro-lino closed 1 year ago

pedro-lino commented 1 year ago

This PR aims to deliver an initial structure of the Algorand integration within the Icon Bridge.

In the algo folder there is the implementation of the Relayer and on the Pyteal one the implementation of the smart contracts.

This is meant to be first of a set of PR iterations, to show Icon our current progress so that they can provide any feedback they see fit and suggest any changes.

However this code was not fully tested yet, despite of having been built without any errors. There is currently a unit test for the receiver module but not for the sender one yet.

There are already initial iterations for the BMC and BSH algorand contracts, with a small set of functionalities and test cases supporting them.

CyrusVorwald commented 1 year ago

This PR is failing some tests. Please run git remote update --prune and try again.

andrii-kl commented 1 year ago

Could you please create a new branch for your implementation, we can't merge this changes directly to the main branch.

CyrusVorwald commented 1 year ago

Could you please create a new branch for your implementation, we can't merge this changes directly to the main branch.

This can be merged after the breaking CI gets fixed, which I believe only requires running git remote update --prune.

@pedro-lino please fix the breaking CI so that this can be merged.

pedro-lino commented 1 year ago

which I believe only requires running git remote update --prune

@CyrusVorwald I already ran this command on my local branch and it fetched the upstream, getting some updates. Also added a git push which returned an Everything up-to-date.

Nothing seemed to have changed on this PR. Should I go ahead and create a new branch on this repo and merge there?

CyrusVorwald commented 1 year ago

which I believe only requires running git remote update --prune

@CyrusVorwald I already ran this command on my local branch and it fetched the upstream, getting some updates. Also added a git push which returned an Everything up-to-date.

Nothing seemed to have changed on this PR. Should I go ahead and create a new branch on this repo and merge there?

Strange. Yeah that's fine

pedro-lino commented 1 year ago

Could you please create a new branch for your implementation, we can't merge this changes directly to the main branch.

Seems that the builds keep failing even not targeting the main branch anymore.

CyrusVorwald commented 1 year ago

The "Build icon-bridge BMR" CI check failure does not seem to be a Github runner associated issue and should be fixed. It fails with

--- FAIL: Test_GetLatestBlock (0.00s) client_test.go:25: Error getting latest round: Get "/v2/status": unsupported protocol scheme "" --- FAIL: Test_Subscribe (0.00s) receiver_test.go:46: Couldn't retrieve latest round

Please take a look. If it's nontrivial to fix and only CI related, continuing to use an independent branch is fine. The other failures are fine.