search

icon-project / icon-sdk-python

ICON SDK for Python
45 stars 45 forks source link

fix generate url map to add channel path #64

Closed yakkle closed 2 years ago

yakkle commented 2 years ago

If channel is empty string, url end with '/'. This regard as empty string of channel path. Mainnet iconrpcserver using default channel if channel path is None. Empty string of channel path raise exception.

related : https://github.com/icon-project/icon-rpc-server/commit/5e95a91fb14829f6309d663c5004ee56759d35f8

sink772 commented 2 years ago

The unit tests are failing with your commit. Please ensure there is no backward compatibility issues. Also it would be good to add tests with your sample urls.

yakkle commented 2 years ago

The unit tests are failing with your commit. Please ensure there is no backward compatibility issues. Also it would be good to add tests with your sample urls.

Fixed.