icon-project / xcall-multi

Apache License 2.0
10 stars 9 forks source link

fix: address validation added in setAdmin #265

Closed gcranju closed 7 months ago

gcranju commented 8 months ago

Description:

Commit Message

fix: address validation added in setAdmin

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eaa0e8f) 68.85% compared to head (05ce937) 68.87%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/icon-project/xcall-multi/pull/265/graphs/tree.svg?width=650&height=150&src=pr&token=KWDB59JITE&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project)](https://app.codecov.io/gh/icon-project/xcall-multi/pull/265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) ```diff @@ Coverage Diff @@ ## development/177-xcall-future-proof-messaging #265 +/- ## ================================================================================== + Coverage 68.85% 68.87% +0.02% Complexity 64 64 ================================================================================== Files 40 40 Lines 2212 2214 +2 Branches 24 24 ================================================================================== + Hits 1523 1525 +2 Misses 679 679 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/icon-project/xcall-multi/pull/265/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | Coverage Δ | | |---|---|---| | [solidity](https://app.codecov.io/gh/icon-project/xcall-multi/pull/265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | `79.17% <100.00%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/icon-project/xcall-multi/pull/265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | Coverage Δ | | |---|---|---| | [contracts/evm/contracts/xcall/CallService.sol](https://app.codecov.io/gh/icon-project/xcall-multi/pull/265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project#diff-Y29udHJhY3RzL2V2bS9jb250cmFjdHMveGNhbGwvQ2FsbFNlcnZpY2Uuc29s) | `83.50% <100.00%> (+0.17%)` | :arrow_up: |