icon-project / xcall-multi

Apache License 2.0
10 stars 8 forks source link

fix: Add support for non null reply encoding #290

Closed AntonAndell closed 3 months ago

AntonAndell commented 3 months ago

When receiving CallMessage results from cosmwasm or EVM it is encoded as empty array instead of null. So this adds handling for when it is a empty array as well.

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.52%. Comparing base (617016e) to head (94be8b5).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/icon-project/xcall-multi/pull/290/graphs/tree.svg?width=650&height=150&src=pr&token=KWDB59JITE&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project)](https://app.codecov.io/gh/icon-project/xcall-multi/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) ```diff @@ Coverage Diff @@ ## main #290 +/- ## ============================================ - Coverage 63.68% 63.52% -0.16% - Complexity 75 76 +1 ============================================ Files 42 42 Lines 2652 2646 -6 Branches 37 37 ============================================ - Hits 1689 1681 -8 - Misses 946 948 +2 Partials 17 17 ``` | [Flag](https://app.codecov.io/gh/icon-project/xcall-multi/pull/290/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | Coverage Δ | | |---|---|---| | [java](https://app.codecov.io/gh/icon-project/xcall-multi/pull/290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | `84.55% <100.00%> (ø)` | | | [rust](https://app.codecov.io/gh/icon-project/xcall-multi/pull/290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | `61.79% <100.00%> (-0.23%)` | :arrow_down: | | [solidity](https://app.codecov.io/gh/icon-project/xcall-multi/pull/290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | `59.20% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/icon-project/xcall-multi/pull/290?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | Coverage Δ | | |---|---|---| | [contracts/cosmwasm-vm/cw-xcall/src/execute\_call.rs](https://app.codecov.io/gh/icon-project/xcall-multi/pull/290?src=pr&el=tree&filepath=contracts%2Fcosmwasm-vm%2Fcw-xcall%2Fsrc%2Fexecute_call.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project#diff-Y29udHJhY3RzL2Nvc213YXNtLXZtL2N3LXhjYWxsL3NyYy9leGVjdXRlX2NhbGwucnM=) | `81.05% <100.00%> (ø)` | | | [...in/java/foundation/icon/xcall/CallServiceImpl.java](https://app.codecov.io/gh/icon-project/xcall-multi/pull/290?src=pr&el=tree&filepath=contracts%2Fjavascore%2Fxcall%2Fsrc%2Fmain%2Fjava%2Ffoundation%2Ficon%2Fxcall%2FCallServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project#diff-Y29udHJhY3RzL2phdmFzY29yZS94Y2FsbC9zcmMvbWFpbi9qYXZhL2ZvdW5kYXRpb24vaWNvbi94Y2FsbC9DYWxsU2VydmljZUltcGwuamF2YQ==) | `84.55% <100.00%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/icon-project/xcall-multi/pull/290/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project)