icon-project / xcall-multi

Apache License 2.0
10 stars 8 forks source link

fix: Use msgPayload hash instead of request data hash for multi protocol verification #322

Closed AntonAndell closed 1 month ago

AntonAndell commented 1 month ago

…col verification

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.32%. Comparing base (1ce06ef) to head (7bc3b3f).

:exclamation: Current head 7bc3b3f differs from pull request most recent head 4adb8c0

Please upload reports for the commit 4adb8c0 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/icon-project/xcall-multi/pull/322/graphs/tree.svg?width=650&height=150&src=pr&token=KWDB59JITE&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project)](https://app.codecov.io/gh/icon-project/xcall-multi/pull/322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) ```diff @@ Coverage Diff @@ ## main #322 +/- ## ========================================= Coverage 89.32% 89.32% Complexity 76 76 ========================================= Files 42 42 Lines 2642 2642 Branches 37 37 ========================================= Hits 2360 2360 Misses 265 265 Partials 17 17 ``` | [Flag](https://app.codecov.io/gh/icon-project/xcall-multi/pull/322/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | Coverage Δ | | |---|---|---| | [solidity](https://app.codecov.io/gh/icon-project/xcall-multi/pull/322/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | `88.75% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/icon-project/xcall-multi/pull/322?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project) | Coverage Δ | | |---|---|---| | [contracts/evm/contracts/xcall/CallService.sol](https://app.codecov.io/gh/icon-project/xcall-multi/pull/322?src=pr&el=tree&filepath=contracts%2Fevm%2Fcontracts%2Fxcall%2FCallService.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=icon-project#diff-Y29udHJhY3RzL2V2bS9jb250cmFjdHMveGNhbGwvQ2FsbFNlcnZpY2Uuc29s) | `97.42% <100.00%> (ø)` | |