search

iconara / rubydoop

Write Hadoop jobs in JRuby
220 stars 33 forks source link

Update Puck from 1.1.0 to 1.2.1 #38

Closed jowl closed 8 years ago

jowl commented 8 years ago

Puck 1.2.0 always calls Kernel.exit on task nodes after the setup script has been run, and this ensures that users use a newer version. The problem doesn't exist on 1.1.x, but I see no reason why not to use the latest version when we have to update the version constraint anyhow.

jowl commented 8 years ago

I can't really see why the tests are failing on Travis for this branch. It feels like I'm missing something trivial, but I can't seem to reproduce the failure on my machine.

jowl commented 8 years ago

Now that I think about it, I don't know if this is the right way to handle this. The only (known) incompatible version of Puck is 1.2.0, and it feels wrong to disallow ~> 1.3 because of that. Or ~> 1.1.0 for that matter.

iconara commented 8 years ago

Maybe we should yank v1.2.0? The exit behaviour isn't great even for non-Hadoop applications. Most won't notice since it's how Ruby works, but if an application uses Java (non-daemon) threads and lets the main thread finish it will be affected.

iconara commented 8 years ago

Just to clarify, I mean yanking Puck v1.2.0. It's probably obvious enough from the context, but just for future archaeologists.

jowl commented 8 years ago

:+1: