iconexperience / svg-inject

A tiny, intuitive, robust, caching solution for injecting SVG files inline into the DOM.
MIT License
0 stars 0 forks source link

Notes on Readme.md #11

Open iconexperience opened 5 years ago

iconexperience commented 5 years ago
  1. Should we keep the empty line in Option 2 souce code?

  2. In chapter "what are the advantages?" the point "Fallback if image source is not available: Behaves like a normal element if file not found or not available." Is not really correct, because this is not a fallback. Maybe "Default behavior" or "Standard behavior" would be better.

  3. IE7/IE8 should not be mentioned, as this does not look contemporary anymore. The chapter "Fallback for no SVG support should be removed and the header "Example with fallback for IE8 & IE7" should be changed to "Example with fallback for no SVG support". Maybe the examples in that chapter should be moved to the Wiki, so the chapter only contains a link.