Cached SVGs not always injected correctly

iconfu / svg-inject

A tiny, intuitive, robust, caching solution for injecting SVG files inline into the DOM.

MIT License

800 stars 85 forks source link

Closed dasboe closed 6 years ago

dasboe commented 6 years ago

Version 1.2.0 introduced a bug where cached images are not always injected.

The problem exists because in Line 540 there is not a distinction between a loadValue Array and a callbackQueue Array.

A test to prevent regression of this this should also be written.

dasboe commented 6 years ago

fixed in 4494c13ae4b3c932a21fc485facb8bd92705e058 and implemented tests to prevent regression of this issue.

fix is part of already released Version 1.2.1