search

iconify / api

Iconify API script. Search engine for icons, provides icon data on demand for icon components, dynamically generates SVG.
MIT License
116 stars 38 forks source link

Why to npm #10

Closed baboon-king closed 1 year ago

baboon-king commented 1 year ago

Just want to know 🧐. Maybe "pnpm" has some problems. https://github.com/iconify/api.js/commit/c8d140cb92218c9d7f7b5a9448ee5bd6126ecac6

cyberalien commented 1 year ago

See https://github.com/iconify/api.js/pull/9

baboon-king commented 1 year ago

I s！ sorry😭 I was too careless

cyberalien commented 1 year ago

For this repo pnpm doesn't really make any difference. I'm using it in dev since it saves a lot of space by removing duplication and is much faster to install/update, but no actual features are used. So any package manager will do.

Since this package is meant to run on servers with lots of various architectures, and pnpm is failing to install on at least one of them, switched to proven package manager.

baboon-king commented 1 year ago

Thanks for your reply again. I've got it at https://github.com/iconify/api.js/pull/9 and https://github.com/iconify/api.js/issues/7