iconify / icon-sets

150+ open source icon sets. Icons are validated, cleaned up, optimised, ready to render as SVG. Updated automatically 3 times a week.
https://icon-sets.iconify.design/
591 stars 56 forks source link

Add Country Flag Icons #30

Closed vhscom closed 2 years ago

vhscom commented 2 years ago

Surprised these aren't in here yet. :smile: https://flagicons.lipis.dev/

cyberalien commented 2 years ago

There was a problem with that icon set a while ago: several icons relied on fonts, making them unusable and icon set was not actively maintained. See https://github.com/lipis/flag-icons/issues/539

However looks like it is maintained now. Will test it.

cyberalien commented 2 years ago

Checked it again. Flags gu and sm still require fonts, so those 2 flags are unusable.

I think I'll add it without those icons.

cyberalien commented 2 years ago

Added.

It will take a while to appear. I'm in process of rewriting script that updates icon sets, this icon set was added to new version, not old version, so icon set will appear only when new script will be fully ready, which should be sometime next week.

Two flags mentioned above will be missing from icon set.

vhscom commented 2 years ago

Awesome. Thanks @cyberalien. Hope the scripting goes well.

vhscom commented 2 years ago

Opened two more issues in the flag icons package to get the other flags cleaned up and linked them to https://github.com/lipis/flag-icons/issues/539. With any luck they'll be finished before the update script is done and can be included with the rest of the flags.

cyberalien commented 2 years ago

Thanks.

With any luck they'll be finished before the update script is done and can be included with the rest of the flags.

It doesn't matter when those icons will be added. Those icons aren't blacklisted, script just checks for font tags inside SVG and ignores icons that contain it. Icon sets are updated several times a week (and I want to change it to faster updates for individual sets within minutes of update being pushed by author to source repository), so it will be automatically added later.

vhscom commented 2 years ago

Solid. :muscle:

cyberalien commented 2 years ago

New update script is finally ready, so icon set is available in API, various NPM packages and Packagist package.

vhscom commented 2 years ago

Fantastic, thanks @cyberalien. :heart: