search

iconify / icon-sets

150+ open source icon sets. Icons are validated, cleaned up, optimised, ready to render as SVG. Updated automatically 3 times a week.
https://icon-sets.iconify.design/
591 stars 56 forks source link

Artifacts in Noto Emoji's coin emoji #39

Closed marwinburesch closed 2 years ago

marwinburesch commented 2 years ago

Hi there,

our team found some artifacts in the noto:coin emoji. The stars seem to have some incorrect coordinates for some of their points. This might have been introduced with this commit since we're relatively sure, that the coin looked just fine about a month ago.

I would love to open a PR and fix this, but there seems to be a significant difference between Google's svg code and your JSON. As I understand I'd need to use the Iconify Tools to generate correct JSON, however that is also a lot of overhead for me.

This is taken from current version of iconify-sets image

This is the current version of googlefonts image

Please let me know what you think and if this can be fixed in the near future.

Cheers guys 👋

cyberalien commented 2 years ago

Thanks a lot for report. That icon is indeed bugged

cyberalien commented 2 years ago

Found and fixed bug that was causing it. Thank you very much for report!

Currently script is updating all packages, it might take up to few hours for fix to appear on API and NPM packages.

Bug affected about 300 icons, in few others I've checked changes are so small that without knowing what to look for bug is not visible. It was caused by error in handling whitespace, which resulted in parts of path being joined incorrectly when path is split over multiple lines.