search

iconify / icon-sets

150+ open source icon sets. Icons are validated, cleaned up, optimised, ready to render as SVG. Updated automatically 3 times a week.
https://icon-sets.iconify.design/
591 stars 56 forks source link

Request: add fluent-emoji from Microsoft #52

Closed kissu closed 2 years ago

kissu commented 2 years ago

It's brand new and a bit special but those are finally open-sourced and quite super cute. 👌🏻 https://github.com/microsoft/fluentui-emoji

cyberalien commented 2 years ago

Awesome.

I've seen PNG version of their new emoji few weeks ago, they look really good. Glad that they've made SVG available and in 3 versions!

cyberalien commented 2 years ago

This might take a while.

Icons are great, but don't pass validation because of some code that doesn't make any sense, such as 

<feFlood flood-opacity="0" result="BackgroundImageFix"/>

Not sure what's going on there, need to re-check specification tomorrow. Maybe filters are bad, maybe I'm missing something in spec.

Also few icons seem to have bad size instead of 32x32: https://github.com/microsoft/fluentui-emoji/issues/34

kissu commented 2 years ago

From what I've quickly glanced, there will probably be some fixes coming soon (next month or so) to the overall project. Some of those issues will probably be addressed at some point.

Thanks for your reactivity btw! 🙏🏻

cyberalien commented 2 years ago

So I've fixed errors in my validator script and converted icon set.

It is somewhat usable. Somewhat.

In other emoji sets average icon size is about 2kb per icon, in simple icon sets such as Material Icons its below 500 bytes per icon.

In Fluent Emoji average icon size is 30463 bytes! When showing 52 icons per page, page freezes for several seconds in Chrome. For each icon hover, it freezes again for a second. I've never seen such massive rendering lag. Issue is caused by huge amount of filters used in each icon, which takes massive amount of CPU time to render.

I'll publish icon set, but for now it is unusable for websites. That's very unfortunate because icons are very cool.

edit: actually, I've overreacted a bit. Sorry. Performance is not as bad as initially tested, so icons are usable. Running local version of API affected my tests. I suspect it has something to do with big JSON file loaded as is on API, which makes filtering icons memory intensive. API servers are definitely going to be suffering from this, but now I have discovered a weak point that needs to be addressed in next version, so it is good.

cyberalien commented 2 years ago

Added! https://icon-sets.iconify.design/fluent-emoji/

I'll add flat and high contrast variations later this weekend.

kissu commented 2 years ago

Damn amazing! Thank you very much. ♥

cyberalien commented 2 years ago

Added Flat and High Contrast versions too.

Unlike default set, these variations don't contain huge number of gradients and filters, so files are small. For flat average size is 2.8kb per icon, for high contrast its 1.7kb... compared to 30kb for default.

High contrast is especially awesome to have because it is basically a good monotone icon set, but for emojis instead of general UI icons. Before this set, the only other monotone emoji set was outdated Emoji One version 1 set.

cyberalien commented 2 years ago

Website has finally rebuilt.

Icon sets are available here: