iconify / icon-sets

150+ open source icon sets. Icons are validated, cleaned up, optimised, ready to render as SVG. Updated automatically 3 times a week.
https://icon-sets.iconify.design/
591 stars 56 forks source link

Grab "optimized" Heroicons, rather than src #56

Closed chasegiunta closed 1 year ago

chasegiunta commented 1 year ago

This is a bit silly, and hopefully an easy fix, but it seems that Iconify may currently be grabbing icons from the heroicons src folder (or somewhere else) rather than the optimized folder.

It looks like the optimized icons have the stroke-width applied to svg rather than the internal path's which allows for css manipulation via the stroke-width rule. It also sets currentColor on the svg, and removes the color attribute on the internal paths.

This is probably more complicated issue, but if possible, it would be ideal to use the optimized icons as to be able to customize the stroke width.

cyberalien commented 1 year ago

It won't make any difference because icon data in Iconify doesn't allow any attributes on SVG element. All attributes are moved to path, so result would be the same.

You can target shapes that use stroke-width with this:

svg [stroke-width="2"] {
    stroke-width: 1.5px !important;
}
chasegiunta commented 1 year ago

Okay, sounds good. Thanks.