search

iconify / icon-sets

150+ open source icon sets. Icons are validated, cleaned up, optimised, ready to render as SVG. Updated automatically 3 times a week.
https://icon-sets.iconify.design/
591 stars 56 forks source link

Invalid license spdx in @iconify-json/mdi package.json #69

Closed firecow closed 1 year ago

firecow commented 1 year ago 
$ npx license-checker-rseidelsohn --development --summary --excludePrivatePackages --onlyAllow "${NPM_LICENSE_CHECKER_ONLY_ALLOW_DEVELOPMENT}" ${exclude_opt}
Package "@iconify-json/mdi@1.1.35" is licensed under "Custom: https://docs.iconify.design/types/iconify-json.html" which is not permitted by the --onlyAllow flag. Exiting.

It would be very very nice to know, what license this package is published under.

Edit: It would be nice, if it has a valid spdx license Apache-2.0 instead of Apache 2.0

https://raw.githubusercontent.com/iconify/icon-sets/master/json/mdi.json It seems like the title is used instead of the spdx, somewhere in the publishing routine.

https://www.npmjs.com/package/@iconify-icons/brandico This one seems to be invalid as well.

I think many of the "packs" use invalid spdx in package.json

cyberalien commented 1 year ago

Thanks for reporting!

Bug confirmed and fixed in parser. I'm running update script to fix all packages, should be fixed soon.

firecow commented 1 year ago

That was fast 😁 Thanks man...