Closed mesqueeb closed 1 year ago
Sure, that can be done.
Currently it is available as pepicons
with mix of icons. It can be split to pepicons-print
for Print version, pepicons-pop
for Pop version or something like that. Would that be ok or do you prefer them split differently?
@cyberalien that would be very kind! That's exactly what I was thinking. : )
Btw is there anything I can set up in my repo to make the process smoother for you ?
Done. Added it to update script, so it will appear as split icon set after tomorrow's update.
Just to avoid confusion. You've mentioned that pop and print icon sets are different and are not meant to be mixed. On your website print icon set has black outline, but in Iconify icon sets it uses icon color for outline. After split it will remain like it was, with currentColor
for outline, not black color. That is not a bug. Mixing hardcoded palette and text color is not acceptable for icons for multiple reasons, so black color is changed to currentColor
by parser.
Icon set was split earlier today.
Just noticed a bug: when browsing icon sets, icon grid is not shown for split icon sets, it will be fixed in next update. It doesn't affect functionality, only shown in icon sets list.
Old pepicons
prefix will continue to be usable, so users who do use icons won't have to change code.
@cyberalien I've recently updated Pepicons to a new major version and have a new icon type "pencil".
I've also improved the exported .zip on my website: https://pepicons.com
Can I help update the pepicons for this library?
Yes, I do need your help to update package.
Parser cannot update it because directory structure has changed. Directory svg
no longer exists, new file and directory names are very confusing, so not sure what's going on there.
Directory names seems to include category + icon type now? What confuses me the most is excessively long icon names, can you tell me how to get icon name from that?
I am rewriting a lot of pepicons now to include these fixes:
svg
folder to be bundled in git repository once more for your build pipelinecurrentColor
instead of both currentColor
and black
opacity="0.2"
instead of 0.8
right nowI will update here when all these fixes are made
@cyberalien If you pull the latest version of pepicons repository: https://github.com/cycraft/pepicons All the issues I mentioned above have been resolved.
Let me know if there are any other considerations on your end.
As for the new type, I'd love to see pepicons-pencil
separate, just like you've done for pepicons-pop
and pepicons-print
. 🙏🏻 🙇🏻
Thanks!
There is one more small issue: many icons are 26x26 instead of 20x20. Is that a bug or intentional?
Icon sets updated, pepicons-pencil
added.
@cyberalien that's a bug 🤔 they should all be 20x20. I'll look into this.
Going forward will pepicons be able to get auto-updated? I'll make sure to not move the svgs folder.
Yes, all icon sets are updated automatically.
Example of 26x26 icon: https://github.com/CyCraft/pepicons/blob/dev/packages/pepicons/svg/pop/alarm-circle-filled.svg
Aha, yes, those -circle type icons are all using a different 26x26 viewbox. That's intentional. But they do keep their width/height at twenty. So without any size adjustments they should appear a bit smaller on the screen (because they have an addintional circle around them)
Btw, I have a list of synonyms per icon to make icons more discoverable (in a JSON). Is there any way you will create a feature where I can provide that to you? Eg. Searching house
will make my house icon show up but not searching home
. So I put home
as a synonym for house
.
Hey, I'm the author of Pepicons: https://github.com/iconify/icon-sets/blob/master/json/pepicons.json
Is there anyway I can provide you with my icon set but split up into 2 separate sets:
Pepicons Print
andPepicons Pop
.As you can see on the website: https://pepicons.com
they're very different and are not meant to be mixed.
Any guidance is much appreciated!