search

iconify / icon-sets

150+ open source icon sets. Icons are validated, cleaned up, optimised, ready to render as SVG. Updated automatically 3 times a week.
https://icon-sets.iconify.design/
564 stars 54 forks source link

Add FlowBite icons #92

Closed Zinidia closed 10 months ago

Zinidia commented 10 months ago

Flowbite's modern icons are rapidly growing in popularity so it makes sense for iconify to include them. See the flowbite icon pack here.

cyberalien commented 10 months ago

Thanks for pull request, however, it cannot be accepted.

This repository is automatically generated, icon set needs to be added to update script that will automatically keep it up to date.

I'll check that icon set.

cyberalien commented 10 months ago

Sorry, that icon set is very low quality. I won't add it.

  1. Icons have random height.

Good icon sets have consistent icon grid, so using multiple icons from same set results in consistently rendered icons. This icon set doesn't. That means using icons with 1em height, which is usually done when using icons, will result in different icons having different visual stroke width because icons with different height won't scale identically.

  1. Some icons are badly designed, using white color for empty parts of icons.

For example, this one: https://github.com/themesberg/flowbite-icons/blob/main/src/solid/e-commerce/cash.svg

Mixing currentColor and white is not acceptable. Icon should work on all backgrounds, not only white background.