search

iconify / iconify-sketch

Sketch plug-in for importing over 100,000 icons from 100+ icon sets, including Material Design Icons, FontAwesome, Jam Icons, Open Emoji and many others.
https://iconify.design/
Apache License 2.0
88 stars 9 forks source link

Launching iconify 2.0.2 immediately crashes Sketch 70.1 running on M1 mac #16

Open jink3 opened 4 years ago

jink3 commented 4 years ago

Launching iconify 2.0.2 immediately crashes Sketch 70.1 running on M1 mac. All other plugins are working fine.

cyberalien commented 4 years ago

Unfortunately I can't replicate that. There is nothing in plug-in that could crash Sketch. All it does at start is it retrieves saved configuration (if it exists) and opens a web view.

Safari could crash Sketch. It currently does crash Sketch when Safari is set to automatically close when closing plug-in, so there is something fishy going on in Sketch communication with Safari.

Can you check if attached plug-in crashes on your computer? It is a basic plug-in created from Sketch template, which uses same web view version (3.4.4) that is used by Iconify plug-in.

my-plugin-name.sketchplugin.zip

jink3 commented 4 years ago

Hey, thanks for that. Yes, your plugin also crashed Sketch in the exact same way. I'm not really sure what the relationship with Safari is though, I don't use Safari at all on my laptop. Anyhow, hoping my confirmation of the crash helps in some way.

cyberalien commented 4 years ago

Sketch uses Safari to display user interface for plug-ins.

Thank you very much for testing, it helps a lot. It confirms that issue is with web view, not with Iconify plug-in. That plug-in is created with Sketch template using skpm create my-plugin --template=skpm/with-webview with sketch-module-web-view updated to version 3.4.4.

Can you post a Sketch crash log in https://github.com/skpm/with-webview/issues/25 and any details you can think of? I think it might help developers figure out what's causing crashes.

jink3 commented 4 years ago

Just posted there, thanks.

digiklug commented 4 years ago
image

this is the issue i see on big sur and version 70 in case it might help you

cyberalien commented 4 years ago

Thanks for report, it is a bug in plug-in, but it is different from this issue. I suspect its a bug that I've fixed in Icon Finder earlier today, but haven't pushed to Sketch plug-in yet.

I'll publish update soon.

cyberalien commented 4 years ago

@digiklug Try 2.0.3, I think it might fix that bug.

digiklug commented 4 years ago

unfortunately not and now there is another issue

image
cyberalien commented 4 years ago

Thanks for reporting! Can't replicate it, but will try to figure it out. I've copied your post to https://github.com/iconify/iconify-sketch/issues/17 because this is a different issue from issue reported by @u-i-1.