search

iconmaster5326 / AetherCraft

A fork of Graknol's Energy Manipulator mod. Turn matter into other kinds of matter today!
5 stars 3 forks source link

avmultiplier shouldn't be applied to recipe result #8

Closed LemADEC closed 10 years ago

LemADEC commented 10 years ago

It appears avmultiplier is applied to recipe results while the ingredients already have the coefficient. For example, with Biomes o'plenty, there's this recipe: 8 Seeds (id 295) around 1 Netherrack (id 87) makes 1 Overgrown netherrack (id 1971 in my case)

with avmultiplier = 1.0 Seed AV is 8 Netherrack AV is 1 Overgrown netherrack is 65 = correct

with avmultiplier = 2.0 Seed AV is 16 = correct Netherrack AV is 2 = correct Overgrown netherrack is 260 = bad (expecting 8 * 16 + 2 = 130)

iconmaster5326 commented 10 years ago

Really, avmultiplier is a hold-over from a time when AVs were integers. I'm thinking of removing this feature entirely (One could emulate this feature simply by cracking open the AV configs). Any opinions?

superckl commented 10 years ago

I've never even had a thought about using the multiplier. It would be a little cumbersome to have to edit all the entries in the config though. How easy would it be to fix this? I looked through the code but couldn't find anything definite.

LemADEC commented 10 years ago

I like the option as it avoid modifying hundreds of line of config.

iconmaster5326 commented 10 years ago

Fixed with commit 24e35a95158c1a80b0b3474ae564bce76c3db216.