icons-pack / react-simple-icons

📦 This package provides the Simple Icons packaged as a set of React components.
MIT License
322 stars 19 forks source link

Draft - DO NOT MERGE #150

Closed LitoMore closed 2 years ago

LitoMore commented 2 years ago

@wootsbot I cannot approve my pull request. It requires another reviewer to approve.

CleanShot 2022-09-27 at 14 47 47@2x
wootsbot commented 2 years ago

@LitoMore I think that at the end of the check I should enable the button, if not, let me know to configure it.

LitoMore commented 2 years ago

@wootsbot In your branch rule settings: https://github.com/icons-pack/react-simple-icons/settings/branches

Click the edit of the main branch in Branch protection rules section.

Then in Protect matching branches section, enable the Restrict who can dismiss pull request reviews, and add me to the list:

CleanShot 2022-09-28 at 23 28 39@2x
wootsbot commented 2 years ago

@wootsbot In your branch rule settings: https://github.com/icons-pack/react-simple-icons/settings/branches

Click the edit of the main branch in Branch protection rules section.

Then in Protect matching branches section, enable the Restrict who can dismiss pull request reviews, and add me to the list:

CleanShot 2022-09-28 at 23 28 39@2x

Ready, thanks for the patience

LitoMore commented 2 years ago

@wootsbot Odd, I still cannot approve my pull request.

CleanShot 2022-09-29 at 10 22 15@2x

Or you could just disable the Require approvals for this project since there are only two maintainers.

wootsbot commented 2 years ago

Ready @LitoMore 😊

LitoMore commented 2 years ago

@wootsbot Hmmm... Still does not work.

CleanShot 2022-09-29 at 12 24 00@2x

Would you mind changing my role to organization owner? I will see where it problem is.

The user role can be changed at https://github.com/orgs/icons-pack/people.

wootsbot commented 2 years ago

Ready @LitoMore 😊

LitoMore commented 2 years ago

I disabled the Require approvals and it's looking good now.

Feel free to switch my role back to member, thanks.

CleanShot 2022-09-30 at 01 13 42@2x