search

icons-pack / react-simple-icons

📦 This package provides the Simple Icons packaged as a set of React components.
MIT License
287 stars 18 forks source link

fix: export everything in package.json #196

Closed bodinsamuel closed 10 months ago

bodinsamuel commented 11 months ago

Right now it's not possible to import icons directly (when using RollupJS) because icons folder is not exposed to resolver

Example this will fail:

const Si1001tracklists = import('@icons-pack/react-simple-icons/icons/Si1001tracklists');

Fail with rollup : https://codesandbox.io/p/github/codesandbox/codesandbox-template-vite-react/csb-8yft4m/draft/tender-tristan?file=/src/App.tsx:8,1 Work with webpack https://codesandbox.io/s/magical-rain-7hjvwk?file=/src/App.tsx

This simple change should do the tricks (tested locally by modifying the package.json in my project)

wootsbot commented 11 months ago

@bodinsamuel I think the Pipeline is broken, I will fix it to merge your pull request

bodinsamuel commented 11 months ago

Is it because of this PR? I'm not used to pnpm Thanks for checking ☺️

wootsbot commented 10 months ago

@bodinsamuel Done, it seems we just need to update from main to bring in the pipeline fix.

bodinsamuel commented 10 months ago

Updated the branch, but seems like it didn't work

wootsbot commented 10 months ago

@bodinsamuel I think we can merge this and see if the pipeline passes in release.

@bodinsamuel I think we just need to add it to the changeset.

pnpm changeset