search

icons-pack / react-simple-icons

📦 This package provides the Simple Icons packaged as a set of React components.
MIT License
310 stars 19 forks source link

Components and README not UpperCamelCase #86

Closed Hahlh closed 2 years ago

Hahlh commented 3 years ago

Good day!

First of all, thank you for maintaining this package!

The README states: image

I am a little confused, as I wouldn't consider capitalizing only the first letter to be UpperCamelCase. Should the description be changed or the component names be corrected?

Two sources about UpperCamelCase: https://wiki.c2.com/?UpperCamelCase https://en.wikipedia.org/wiki/Camel_case

wootsbot commented 3 years ago

@Hahlh thanks for your issue, the names of the react components are wrongly named, we should rename them to this MyComponent.

If you already have a utility to rename all the components you would be happy to merge your pr, since there are components that are named this way in the data of simple-icons

gptkrsh commented 3 years ago

Can I instead make a pr on the simple-icons pr asking them to merge it to make all the names camelcase?

Hahlh commented 2 years ago

Hey there @wootsbot! :slightly_smiling_face:

I actually just saw this as it was closed, please excuse getting back to you so late. I assume the issue is settled?