search

icons8 / line-awesome

Replace Font Awesome with modern line icons
https://icons8.com/line-awesome
Other
1.25k stars 141 forks source link

Sass deprecation warning #100

Open Akromangel opened 1 year ago

Akromangel commented 1 year ago

After upgrading to Angular 15.2 we started to get warnings:

... line-awesome.scss - Warning: Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
13:12:26  Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
13:12:26  
13:12:26  
13:12:26  Build at: 2023-05-12T10:12:21.529Z - Hash: f9ec639a3f1a2f9a - Time: 63786ms
13:12:26  Recommendation: math.div(4em, 14) or calc(4em / 14)
13:12:26  
13:12:26  More info and automated migrator: https://sass-lang.com/d/slash-div
13:12:26  
13:12:26  node_modules/line-awesome/dist/line-awesome/scss/_list.scss 17:28       @import
13:12:26  node_modules/line-awesome/dist/line-awesome/scss/line-awesome.scss 7:9  root stylesheet

I kindly ask to fix these warnings.

herlangga-pakar-it commented 1 year ago

ooh so now it need to use calc() if divide

Brain8torm commented 5 months ago

Same issue.

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(4em, 14) or calc(4em / 14)

simonhammes commented 5 months ago

This was already fixed in https://github.com/icons8/line-awesome/commit/db2d9fcc864e25a68c4cdb0a3c49b60fc657196d, but there is no new release :slightly_frowning_face:

See https://github.com/icons8/line-awesome/issues/107

rcheetah commented 4 months ago

For everyone who's looking for a quick fix until this is resolved: You can actually depend directly on the GitHub version of this repository by changing the dependency in your package.json to:

"line-awesome": "icons8/line-awesome.git"

Keep in mind that this is not version-controlled and will always fetch the latest version from the main branch. So, keep an eye out for potential bugs or breaking changes that would not be captured by the default syntax.