icosa-foundation / icosa-gallery

Icosa Gallery is a 3D model hosting solution, intended as a replacement for Google's Poly
https://icosa.gallery
5 stars 0 forks source link

Suggest to loosen the dependency on databases #3

Closed Agnes-U closed 1 year ago

Agnes-U commented 1 year ago

Hi, your project icosa-api(commit id: 38396adceea252c0bc4fc4d97a17b2eb852028fb) requires "databases==0.4.1" in its dependency. After analyzing the source code, we found that the following versions of databases can also be suitable, i.e., databases 0.4.0, 0.4.2, 0.4.3, 0.5.0, 0.5.1, 0.5.2, 0.5.3, 0.5.4, 0.5.5, since all functions that you directly (1 APIs: databases.core.Database.init) or indirectly (propagate to 3 databases's internal APIs and 3 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on databases from "databases==0.4.1" to "databases>=0.4.0,<=0.5.5". This will improve the applicability of icosa-api and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on databases?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

foxtrotluna commented 1 year ago

Hello, we don't deem this important right now, if we were to add dependency checks, we would use a tool such as dependabot in future. Please don't run this bot on this repository in future.

Best of luck with writing the tool though!