search

icosa-foundation / icosa-gallery

Icosa Gallery is a 3D model hosting solution, intended as a replacement for Google's Poly
https://icosa.gallery
Apache License 2.0
9 stars 0 forks source link

"Web XR" not available can be much more subtle #59

Open andybak opened 2 months ago

andybak commented 2 months ago

tooltip over a small xr icon?

mikeskydev commented 2 months ago

This is the default button supplied by the webxr module that does prechecks to see if any component of webxr is possible https://github.com/mrdoob/three.js/blob/master/examples/jsm/webxr/VRButton.js#L3. extracting that out and doing styling/code ourselves is probably optimal.

mikeskydev commented 2 months ago

may also want to switch it to the code found in XR Button, which should unlock immersive-ar https://github.com/mrdoob/three.js/blob/master/examples/jsm/webxr/XRButton.js

andybak commented 2 months ago

There's also an ARButton: https://github.com/mrdoob/three.js/blob/master/examples/jsm/webxr/ARButton.js

which seems to work although the model isn't visible when i switch to AR mode. I think this is off-topic for this ticket but it's an interesting discovery.