search

icosa-foundation / open-brush

Open Brush is the open source, community led evolution of Tilt Brush! Forked from https://github.com/googlevr/tilt-brush
https://openbrush.app
Apache License 2.0
855 stars 176 forks source link

Normal maps in exports #308

Open andybak opened 1 year ago

andybak commented 1 year ago

@mikeskydev - I've created a branch: https://github.com/icosa-gallery/open-brush/tree/feature/normal-map-exports

In that branch I've converted the texture maps. I think the next step is to edit Support/GlTFShaders/include/NormalMap.glsl so that it just samples the normal map normally (pardon the pun) instead of doing all the stuff with derivitives. I'd appreciate your help with this.

After that I'm a bit hazy:

  1. We'll need to update the Toolkit/SDK with the new texture maps
  2. We'll need to track down anywhere that uses the glsl shader code and update it.

I can handle (1) - don't know enough about (2) at the moment. Any thoughts?

mikeskydev commented 1 year ago

Will defer until #278 is in?

andybak commented 1 year ago

I don't think there's a lot of overlap between the two issues - either in terms of files that are affected or more structurally. Even if #278 expanded to cover export, it doesn't care about how the texture maps and shaders interact.