search

icosa-foundation / open-brush

Open Brush is the open source, community led evolution of Tilt Brush! Forked from https://github.com/googlevr/tilt-brush
https://openbrush.app
Apache License 2.0
842 stars 175 forks source link

Properly investigate/fix RenderWrapper.cs Depth Blit #691

Open mikeskydev opened 5 months ago

mikeskydev commented 5 months ago

RenderWrapper.cs was failing to properly blit depth during it's offscreen rendering on PCVR.

Mobile skips certain steps, so it works fine.

I temporarily worked around this in #685 but it may have side effects, notably we still need offscreen render for recording with camera.

This may be a Unity bug, but let's investigate and fix where we can.

More information in #420

mikeskydev commented 4 months ago

Not sure if URP only, but noting that there's supposedly an issue that was fixed in Unity 6 involving alpha second-cam rendering. https://forum.unity.com/threads/post-processing-with-multiple-cameras-is-currently-very-problematic.1028533/ An alpha preservation checkbox has been added in Unity 6000.0.0 Beta 16. Thank you to everyone who contributed to the thread and submitted a use case!