search

icosa-foundation / open-brush

Open Brush is the open source, community led evolution of Tilt Brush! Forked from https://github.com/googlevr/tilt-brush
https://openbrush.app
Apache License 2.0
777 stars 166 forks source link

Enable file system watcher on mobile #704

Closed andybak closed 2 months ago

andybak commented 2 months ago

Let's see if this works now

mikeskydev commented 2 months ago

Please can this be tested on Q1!

andybak commented 2 months ago

Please can this be tested on Q1!

I don't currently have access to a Quest 1. Do you?

mikeage commented 2 months ago

I can test Q1 tonight, just please tell me what specifically to look out for

andybak commented 2 months ago

This fixes the bug on Quest 3 at least. @mikeage - I think we just need to test that it doesn't make anything worse on Quest 1.

Try using the Media Library browser and see if it does anything weird.

If it's working, then you should be able to add new images into the media library with Open Brush running and see them appear as previews in the Media Library panel instantly.

If it's not working but not breaking stuff then they just won't appear.

If it's breaking stuff then... dunno. Weird stuff will happen?

mikeage commented 2 months ago

Works on Q1. Pushing or deleting an image immediately brings up the "loading images" screen and then the new one is seen automatically.

@mikeskydev , do we need to test other platforms, Pico, etc.? Or did you ask about Q1 because that's the only one you don't have.

mikeskydev commented 2 months ago

I was mainly concerned about the performance implications of the watcher, but that sounds fine!

mikeage commented 2 months ago

it didn't seem to cause anything (assuming it's inotify under the hood, it should be zero impact)

mikeage commented 2 months ago

I'm approving, but let's not merge until I fix the DMG build

mikeage commented 2 months ago

this is ready to go, as soon as the build on main finishes