search

icosa-foundation / open-brush

Open Brush is the open source, community led evolution of Tilt Brush! Forked from https://github.com/googlevr/tilt-brush
https://openbrush.app
Apache License 2.0
842 stars 175 forks source link

Support Pico on OpenXR #721

Open mikeskydev opened 4 months ago

mikeskydev commented 4 months ago

Adds Android input mappings for Pico devices to OpenXR using their official plugin, mirrored to Icosa's mirror repo. Need to test against other platforms.

mikeage commented 4 months ago

If I'm not mistaken, the clash is not between Oculus and Pico, but rather Pico-from-git and Pico-from-zip

mikeskydev commented 4 months ago

Correct, but both a result of pico copying oculus' meta files, and then additionally using the meta files/code in both of their packages, a big no no 😂

mikeage commented 4 months ago

But didn't you fix that in the both the git mirror and in our build script? I don't think the problematic Common.cs.meta file is actually found anywhere, is it?

Actually, looking more carefully at the logs, isn't it because of this:

Library/PackageCache/com.unity.xr.openxr.picoxr@0c6e35dbf6/Platform/Editor/PicoGs.cs(37,55): error CS1061: 'PXR_PlatformSetting' does not contain a definition for 'useHighlight' and no accessible extension method 'useHighlight' accepting a first argument of type 'PXR_PlatformSetting' could be found (are you missing a using directive or an assembly reference?)
Library/PackageCache/com.unity.xr.openxr.picoxr@0c6e35dbf6/Platform/Editor/PicoGs.cs(40,46): error CS1061: 'PXR_PlatformSetting' does not contain a definition for 'useHighlight' and no accessible extension method 'useHighlight' accepting a first argument of type 'PXR_PlatformSetting' could be found (are you missing a using directive or an assembly reference?)