icpcsec / livesite

Web app for spectators of programming contests
Apache License 2.0
9 stars 2 forks source link

Warning: componentWillMount has been renamed — SideEffect(DocumentTitle) #54

Open tossy310 opened 2 months ago

tossy310 commented 2 months ago
react-dom.development.js:67 Warning: componentWillMount has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: SideEffect(DocumentTitle)

We use https://github.com/gaearon/react-document-title from DocumentTitleUpdater, and react-document-title depends on https://github.com/gaearon/react-side-effect, which uses componentWillMount.

We may need to find alternative way to update the document title.

tossy310 commented 2 months ago

And this is a blocker to update react to 18.