search

icra / ecam

Energy performance and Carbon emissions Assessment and Monitoring tool (Lluís Bosch, Lluís Corominas, IWA, Wacclim project, GIZ)
http://wacclim.org/ecam
Other
13 stars 17 forks source link

GHG due to non revenue water equations #92

Closed holalluis closed 6 years ago

holalluis commented 6 years ago

The discussion was: change name to "due to water losses" wsa_SL_GHG_nrw wst_SL_GHG_nrw wsd_SL_GHG_nrw wsd_SL_ghg_attr

Summary of formulas: Water losses is "wsd_vol_dist - wsd_auth_con" Non revenue water is "wsd_vol_dist - wsd_bill_con" image

Porro1jc commented 6 years ago

let's make this based on the water loss

Porro1jc commented 6 years ago

@holalluis @Ranf16 @harora16

Follow this format for each. It is ok for now that variable has nrw in it. Not a big deal...

image

holalluis commented 6 years ago

ok. Please keep in mind that if I change the description in English, the french, spanish and thai will still have the "due to non revenue water" instead of water losses, so, it is better to change it now also, so please provide the translation for the other languages for this text change.

Porro1jc commented 6 years ago

We will not translate now we will worry about that at a later time

Sent from my iPhone

On May 30, 2018, at 2:26 PM, Lluís Bosch notifications@github.com<mailto:notifications@github.com> wrote:

ok. Please keep in mind that if I change the description in English, the french, spanish and thai will still have the "due to non revenue water" instead of water losses, so, it is better to change it now also, so please provide the translation for the other languages for this text change.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/icra/ecam/issues/92#issuecomment-393268048, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AToH22vhN8zV12F1fgNBE8Ewoz1gXiMHks5t3uRfgaJpZM4UNCdv.

holalluis commented 6 years ago

ok, I've removed the old translation for languages other than english and added the language tag to the new tags to be translated

holalluis commented 6 years ago

done

Porro1jc commented 6 years ago

Maybe I am not understanding... If we have things translated, we want to keep them, but for this version we will not show translations until we have everything translated for at least one language. So I would do a save as on the text file so you do not have to retranslate that are already translated.

holalluis commented 6 years ago

yes, I've just deleted the tags which need to be retranslated because of the text change, and I will add them to the new ones, as if they were new language tags. I have not deleted the ones that are already translated