search

ics-jku / wal

WAL enables programmable waveform analysis.
https://wal-lang.org
BSD 3-Clause "New" or "Revised" License
116 stars 18 forks source link

remove dataclasses from install requirement #24

Closed Avimitin closed 8 months ago

Avimitin commented 8 months ago

dataclasses is built-in into python 3.7. Since python_requires is specified with '>=3.8', we can assume that the dataclass module is exists. If we don't remove this dependency, setuptools will try to find 'dataclasses' from distribution cache, not from built-in, and thus cause install error.

Avimitin commented 8 months ago

importlib-resource can be removed too. It was introduced in python 3.1, no need to specified them in dependencies. I will update this pr later.

LucasKl commented 8 months ago

Good catches, thank you!