search

icsharpcode / AvaloniaILSpy

Avalonia-based .NET Decompiler (port of ILSpy)
1.5k stars 169 forks source link

Supressed compiler warning #100

Closed TheEpicFace007 closed 2 years ago

TheEpicFace007 commented 2 years ago

This pull request supresses the following warning:

christophwille commented 2 years ago

That's at least not how I'd like those to be fixed - obsolete should be replaced by their non-obsolete counterparts, and new to hide is something I consider a code smell (do we really need to hide it? Is it an unintentional naming clash? Did it happen because Avalonia changed naming? ...).

TheEpicFace007 commented 2 years ago

That's at least not how I'd like those to be fixed - obsolete should be replaced by their non-obsolete counterparts,

I do agree with you however in the meantime it should avoid code smell as it serve as a indicator to remember that it's urgent to update the deprecated method.

(do we really need to hide it? Is it an unintentional naming clash?

Yes. According to microsoft doc it sorta is naming clash as it ignore what was the inheritted value was in the parent class. I suggest you to give a read this documentation about the new identifier to understand why it avoid code smell.

jeffreye commented 2 years ago

was fixed in #109