Closed sable-starflower closed 2 years ago
I think the proper fix for this would be https://github.com/icsharpcode/ILSpy/commit/d8f74cf33e9ee06a61d5490771440f487fe83b2c
Using your fix the button is not added/stops working, if the tree node was not expanded previously. Calling EnsureLazyChildren
makes sure that the nodes are added before looking for the right one and prevents the crash.
Oh great, thanks! I updated with the suggested fix, feel free to merge if that looks okay.
@sable-starflower can you move assemblyNode
and its logics inside delegate as https://github.com/icsharpcode/ILSpy/commit/d8f74cf33e9ee06a61d5490771440f487fe83b2c does?
Oh yeah, sorry for missing that. Done!
I'm not entirely sure why this crash happens, or whether this is the right fix for it, but I figured including a bit of code was better than just pasting a stack trace into an issue. Here's the stack trace: