Closed bbenzikry closed 3 years ago
What do you mean by "remove the deprecated repo"?
Why would we do that? (aside from how)
Well, given that jeffreye/AvaloniaILSpy is archived, IMHO it makes sense that this becomes the main repository, under the org - unless I'm missing something and as long as @jeffreye doesn't have a problem with that.
As for homebrew - if this doesn't happen, I'll need to either build from source or use releases published outside of github. I would have used a direct link from the github action artifacts to make this easier for everyone but there are issues with this for non logged in users ( see https://github.com/actions/upload-artifact/issues/51 ) I also don't think it'll be smart to rely on something like https://nightly.link
As for how - If I'm not mistaken this can happen automatically if you change the repo visibility to private
Repo visibility- you mean the originating repo? (the other way round would be strange)
I know nothing about publishing to homebrew, so... I'm not going to be of much help.
Yeah, the originating repo 😄
@christophwille Any way to get in touch with @jeffreye and see if it's possible?
https://github.com/icsharpcode/AvaloniaILSpy/releases/tag/v7.0-rc1 I made this as an actual release.
Thanks @jeffreye - what are your thoughts about removing / hiding the original repository?
The repo has been archived, and it has a link in description for redirecting people to this repo. So technically, it's already deprecated. Not sure how removing would help.
From: Beni Ben zikry @.> Sent: Monday, April 26, 2021 2:41:23 AM To: icsharpcode/AvaloniaILSpy @.> Cc: Jeffrey Ye @.>; Mention @.> Subject: Re: [icsharpcode/AvaloniaILSpy] Homebrew based install (#64)
Thanks @jeffreyehttps://github.com/jeffreye - what are your thoughts about removing / hiding the original repository?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/icsharpcode/AvaloniaILSpy/issues/64#issuecomment-826682713, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AANIHUG4Q7POWP34RIDQYYTTKUYMHANCNFSM43DCMQQA.
The repo has been archived, and it has a link in description for redirecting people to this repo. So technically, it's already deprecated. Not sure how removing would help. … ____ From: Beni Ben zikry @.> Sent: Monday, April 26, 2021 2:41:23 AM To: icsharpcode/AvaloniaILSpy @.> Cc: Jeffrey Ye @.>; Mention @.> Subject: Re: [icsharpcode/AvaloniaILSpy] Homebrew based install (#64) Thanks @jeffreyehttps://github.com/jeffreye - what are your thoughts about removing / hiding the original repository? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#64 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AANIHUG4Q7POWP34RIDQYYTTKUYMHANCNFSM43DCMQQA.
Hi @jeffreye, as I explained, as long as the repo is not hidden manually, this repo is considered as a fork and won't easily pass homebrew's requirements. You can always make it visible again afterwards.
@bbenzikry i just hide my repo, but it seems it's getting worse. It shows it forked from VitalElement/AvaloniaILSpy @christophwille is there something we could do on the setting page?
Hmm I didn’t realize it’s part of a chain. From what I’ve been reading it seems there are two ways to deal with it - do the same with the Avalon repo or contact GitHub support. As long as it’s clear that this is the main repository where work is being done, they should be able to comply.
"As long as it’s clear that this is the main repository" well... given that the commits are from Jeffrey, I think it should be Jeffrey that asks GH support to do that. Just so it is crystal-clear that it is his intention to make this the main repo.
Detached.
From: Christoph Wille @.> Sent: Monday, April 26, 2021 10:04:12 PM To: icsharpcode/AvaloniaILSpy @.> Cc: Jeffrey Ye @.>; Mention @.> Subject: Re: [icsharpcode/AvaloniaILSpy] Homebrew based install (#64)
"As long as it’s clear that this is the main repository" well... given that the commits are from Jeffrey, I think it should be Jeffrey that asks GH support to do that. Just so it is crystal-clear that it is his intention to make this the main repo.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/icsharpcode/AvaloniaILSpy/issues/64#issuecomment-827314311, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AANIHUDHOAGZWOTS7MZFBK3TKZAUZANCNFSM43DCMQQA.
Looking good (in the sense it doesn't say "forked from..." any more)
Great, I'll finalize the PR by tomorrow. Once it's approved I'll close this issue.
Hi, a small update - it's taking a while for the PR to go through on the homebrew-cask side, but all checks have passed successfully
PR has been merged. Thanks for all the help :)
For documentation purposes: can be found at https://formulae.brew.sh/cask/ilspy#default
Hi there, I've added a PR to homebrew cask here https://github.com/Homebrew/homebrew-cask/pull/104173
The audit currently fails to pass
As #62 mentions, a new release is probably a good idea. Will it be possible to add this release as an actual release and not a pre-release and remove the deprecated repo? Once this is done I'll be sure to update the cask PR