Const string reference replaced by string literal value

[Aussiemon]

Similar to #1084.

The reference to const kPlantableNameKey is replaced by its value in the constructor, which is valid code, but an unused assignment / variable warning at the IDE. Perhaps the decompiler could check for private constants and replace matching literals in scope, or perhaps this is a more specific edge case.

Input code

public class TestDecomp
{
    private const string kPlantableNameKey = "Chamomile";

    public string GetPlantableNameKey()
    {
        return kPlantableNameKey;
    }
}

Erroneous output (from .NET 8.0 SDK class library)

public class TestDecomp
{
    private const string kPlantableNameKey = "Chamomile";

    public string GetPlantableNameKey()
    {
        return "Chamomile";
    }
}

Details

• Product in use: ILSpy
• Version in use: ILSpy 9.0 Preview 2

[siegfriedpammer]

This is not a bug, but a request for improvement. While we do some prettifying of double and float constants, that can be expressed as fractions or multiples of Math.PI or E, I don't think this case is worth the effort.

Questions:

1. Where should we look for constants? Current type, current assembly or all referenced assemblies?
2. Should we look at possible sub strings?

These two questions are examples of why such a feature is problematic in my opinion.