icsharpcode / NRefactory

NRefactory - Refactoring Your C# Code
684 stars 262 forks source link

NRefactory6 #474

Closed Kavignon closed 9 years ago

mkrueger commented 9 years ago

Commits from master --> roslyn are a bad idea as well. Both branches are too different. The only thing they could share is potentially the unit tests.

Therefore : Do no auto merge these branches. They're basically incompatible.

Kavignon commented 9 years ago

Instead of pull request, could I simply do a fork ?

On Sun, Mar 22, 2015 at 1:42 PM, Mike Krüger notifications@github.com wrote:

Closed #474 https://github.com/icsharpcode/NRefactory/pull/474.

— Reply to this email directly or view it on GitHub https://github.com/icsharpcode/NRefactory/pull/474#event-261660490.

Kavignon commented 9 years ago

Or would it be better to have my own branch ?

On Sun, Mar 22, 2015 at 1:48 PM, Kevin Avignon kevin.o.avignon@gmail.com wrote:

Instead of pull request, could I simply do a fork ?

On Sun, Mar 22, 2015 at 1:42 PM, Mike Krüger notifications@github.com wrote:

Closed #474 https://github.com/icsharpcode/NRefactory/pull/474.

— Reply to this email directly or view it on GitHub https://github.com/icsharpcode/NRefactory/pull/474#event-261660490.

mkrueger commented 9 years ago

What are you trying to do ?

In general it's better if you fork and have your own branch and make pull requests from that to the branch you're working on.

Kavignon commented 7 years ago

Kevin Avignon would like to connect on LinkedIn. How would you like to respond?

Accept: https://www.linkedin.com/comm/start/accept-invitation?sharedKey=hNJoKxXe&invitationId=6208290943687282690&trk=eml-first_guest_reminder_01-hero-121-accept_text&trkEmail=eml-first_guest_reminder_01-hero-121-accept_text-null-%7Ea92j94%7Eiw6msic6%7Ec8

View Kevin Avignon's profile: https://www.linkedin.com/comm/start/accept-invitation?sharedKey=hNJoKxXe&invitationId=6208290943687282690&trk=eml-first_guest_reminder_01-hero-3-profile_text&trkEmail=eml-first_guest_reminder_01-hero-3-profile_text-null-%7Ea92j94%7Eiw6msic6%7Ec8

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/e/v2?e=-a92j94-iw6msic6-c8&t=lun&midToken=AQFmrFVhGEd36Q&ek=first_guest_reminder_01&li=123&m=unsub&ts=HTML&eid=-a92j94-iw6msic6-c8&loid=AQEYmpuvWVvCfQAAAVi8NrcGmh51uFJgOiwdzqd8Yh13CeLYGUPHZw-MfHNb0x_9lm23vH8koCBbft1TJDbqVsHJwqfA4zsy7x4jdG67-Zh9MX5PMuxZ8SioXvwPPM0ef5lmD_Nqk8n-talYUOAeXVZgVlHxGWCZ_-jucDeghiT9J7mYkdnhE0orTAdLs9VjWPmvvHYi1zV3BLaYg-_mW68jS627lA

This email was sent to reply@reply.github.com.

If you need assistance or have questions, please contact LinkedIn Customer Service: https://www.linkedin.com/e/v2?e=-a92j94-iw6msic6-c8&a=customerServiceUrl&ek=first_guest_reminder_01

© 2016 LinkedIn Corporation, 2029 Stierlin Court, Mountain View CA 94043. LinkedIn and the LinkedIn logo are registered trademarks of LinkedIn.