search

icsharpcode / SharpDevelop

#develop (short for SharpDevelop) is a free IDE for .NET programming languages.
2.09k stars 773 forks source link

Allow setting the underline attribute for syntax highlight elements #505

Closed julodnik closed 10 years ago

julodnik commented 10 years ago

With this patch a new option appears in the dialog Options|Text Editor|Highlighting : "Underline" (under bold and italic)

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the #develop open source product (the "Contribution"). My Contribution is licensed under the MIT License.

dgrunwald commented 10 years ago

Your changes look OK except for the two minor issues I commented on. Can you fix those? Also, there's a bit of inconsistent indentation (mixing tabs and spaces).

julodnik commented 10 years ago

You are right, I forgot to transfer the changes of the file ModeV2.xsd. The change on HighlightingColorizer.cs:257 is in fact useless, since the underline property is being evaluated in the 268. As for the tabulators and space, it should be fixed now. Why did you guys decided to use tabs instead of spaces? They produce only headaches and have in times of cheap memory no longer any utility.

julodnik commented 10 years ago

Will this ever be pulled or is it being stalled on purpose? Do I need to do something else?

dgrunwald commented 10 years ago

We just didn't have time to review this until now. I've merged your changes (by rebasing) as a81b6c234937c4b17fc906bf91a6c52529bb1e88..293edbf7310a0bf71a4339349947d4cd8e787183, and fixed some bugs in 8ace2341fb6babcb202708c8d887ffb913142a3e.