search

icsharpcode / SharpDevelop

#develop (short for SharpDevelop) is a free IDE for .NET programming languages.
2.09k stars 773 forks source link

Drop GetEnumerator() method in CodeElements interface to fix warning #512

Closed linquize closed 10 years ago

mrward commented 10 years ago

Had look back at the commit history to remember why this was left with the warning but it is intentional, maybe not the warning, but the GetEnumerator() method. It is a long time ago that this change was made I had almost forgotten :smile:

https://github.com/icsharpcode/SharpDevelop/commit/177f0190b6d000432c78a0643653230e18197282

Without the GetEnumerator() on the CodeElements there was a problem compiling the MvcScaffolding unit tests.

linquize commented 10 years ago

No, AspNet.Mvc.Tests all successful. What was wrong?

mrward commented 10 years ago

MvcScaffolding is a different project, not part of SharpDevelop. It is used to create the MvcScaffolding.SharpDevelop NuGet package.

I believe the problem was to do with PowerShell. I should have put more information into the commit message really :(

dgrunwald commented 10 years ago

When method hiding is intentional, use the Shadow modifier (new in C#) to suppress the compiler warning.