icsharpcode / SharpDevelop

#develop (short for SharpDevelop) is a free IDE for .NET programming languages.
2.09k stars 773 forks source link

"Comment region" shortcut does not working #566

Closed turbanoff closed 10 years ago

turbanoff commented 10 years ago

Ctrl + / on press nothing happend. Action in context menu working properly

SD 5.0 RC. build 4696

Rpinski commented 10 years ago

Hi, which keyboard layout do you use? In a quick test I couldn't reproduce it with an US layout.

turbanoff commented 10 years ago

US layout.

turbanoff commented 10 years ago

After change this line shortcut worked. https://github.com/icsharpcode/SharpDevelop/blob/master/src/Main/Base/Project/ICSharpCode.SharpDevelop.addin#L2074 to shortcut="Control|Divide"

Rpinski commented 10 years ago

I'm still not sure whether you press the correct key. On a US layout this is what you need to press for Ctrl+/:

ctrl_slash_us

I tried that and it worked.

turbanoff commented 10 years ago

Hm. You are right, with this key works well. But usuaslly use key / on num pad. Is it possible to support this key too?

dgrunwald commented 10 years ago

shortcut="Control|Divide" won't work correctly on keyboard layouts where / is not its own key -- for example on the German keyboard layout, / is on Shift+7, and OemQuestion maps to the # key instead.

turbanoff commented 10 years ago

May be possible support two shortcut? I'm not sure of the concrete solutions, just want to work with numpad /. And I'm sure I'm not alone