icsharpcode / SharpDevelop

#develop (short for SharpDevelop) is a free IDE for .NET programming languages.
2.09k stars 773 forks source link

Assembly Info Editor. TextBox for assembly informational version. #641

Closed olegbevz closed 9 years ago

olegbevz commented 9 years ago

We can put any string for assembly informational version, not just "1.0.0.0" string. Link: http://stackoverflow.com/questions/64602/what-are-differences-between-assemblyversion-assemblyfileversion-and-assemblyin. So there should be a textbox for assembly informational version on assembly info panel .

siegfriedpammer commented 9 years ago

Thanks for your pull request. Please mind tabs vs. spaces in the indentation. Can you fix your commit and do a force push or create a new pull request?

olegbevz commented 9 years ago

I've fixed the indenting at AssemblyInfoProvider.cs 133. Is it all right now?

Rpinski commented 9 years ago

Yep, looks ok now. Thank you!

Rpinski commented 9 years ago

@olegbevz Please pay attention to the unit tests in future pull requests, because code changes might break the unit test project or at least cause some tests to fail.

olegbevz commented 9 years ago

Sorry, too many mistakes from me: indenting and broken tests. Maybe it's because i had holidays. I'll be more attentive in future.