search

icsharpcode / SharpZipLib

#ziplib is a Zip, GZip, Tar and BZip2 library written entirely in C# for the .NET platform.
http://icsharpcode.github.io/SharpZipLib/
MIT License
3.73k stars 976 forks source link

fix(zip): 0 in zip64 local sizes using descriptors #750

Closed piksel closed 2 years ago

piksel commented 2 years ago

In #736, the header tests were changed to allow for 0 being passed as the Zip64 sizes when testing the archive. That is actually the correct value as per the spec, and hence this updates the output of ZipFormat.WriteLocalHeader to write 0 when using descriptors together with Zip64.

Fixes #744

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

codecov[bot] commented 2 years ago

Codecov Report

Merging #750 (713db5e) into master (aee3b44) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files          69       69           
  Lines        8355     8355           
=======================================
  Hits         6169     6169           
  Misses       2186     2186
Impacted Files Coverage Δ
src/ICSharpCode.SharpZipLib/Zip/ZipFile.cs 77.28% <100.00%> (ø)
src/ICSharpCode.SharpZipLib/Zip/ZipFormat.cs 89.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aee3b44...713db5e. Read the comment docs.

carlreid commented 2 years ago

Any thoughts on when a new release will be made which includes this fix?

SourceproStudio commented 2 years ago

这是来自QQ邮箱的假期自动回复邮件。   您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

piksel commented 2 years ago

@carlreid no release date, but I should have the time to do so pretty soon. sorry that I cannot be more specific.

carlreid commented 2 years ago

sorry that I cannot be more specific.

No stress! We can wait a little more