search

icsharpcode / SharpZipLib

#ziplib is a Zip, GZip, Tar and BZip2 library written entirely in C# for the .NET platform.
http://icsharpcode.github.io/SharpZipLib/
MIT License
3.7k stars 976 forks source link

Undesirable Console log while reading #807

Closed PalfLex closed 1 year ago

PalfLex commented 1 year ago

Steps to reproduce

  1. It happens every time when the InitialRead method is called.

Expected behavior

This method should not write information ("Input Encoding:" and "Input Bytes") into the console.

Actual behavior

Since the new version 1.4.1 (Commit: a389d9f521dc5ddeae575511dc918b22baab22a5; "fix(zip): cleanup/fix of StringCodec") there those two lines of code (line 577 and 597 in ZipInputStream) which always write into the console log.

Could you please fix this, or add an variable to disable this console log?

Thanks

Version of SharpZipLib

Current Version: 1.4.1

Obtained from (only keep the relevant lines)

piksel commented 1 year ago

Yeah, that was never supposed to be committed. Sorry about that. I'll try to release a new version fairly soon with this removed.

PalfLex commented 1 year ago

Dear Piksel, thank you very much for answering this fast and for correcting this issue.

PalfLex commented 1 year ago

Dear Piksel, when are you going to put a new version with the fix online? :)

piksel commented 1 year ago

@PalfLex There were some concurrency bugs when testing in CI, so I put the new release on hold until I could isolate the cause. I have not been able to reproduce the problems since then, so I am leaning towards ignoring it for now anyway. Sorry for the delay.