icsharpcode / SharpZipLib

#ziplib is a Zip, GZip, Tar and BZip2 library written entirely in C# for the .NET platform.
http://icsharpcode.github.io/SharpZipLib/
MIT License
3.7k stars 976 forks source link

SharpZipLib v1.4 introduced breaking change #839

Closed Bykiev closed 1 year ago

Bykiev commented 1 year ago

Describe the bug

ZipFile class constructor prior v1.4 had this constructor: public ZipFile(string name)

In v1.4 optional parameter StringCodec was added which causing Method not found exception in other libraries built with older versions of SharpZipLib. It's a breaking change, instead of adding optional parameter you should create 2 separate constructors.

Updating SharpZipLib to v1.4 breaks NPOI: https://github.com/nissl-lab/npoi/issues/1149

Reproduction Code

No response

Steps to reproduce

described

Expected behavior

No breaking change should be introduced

Operating System

Windows, macOS, Linux

Framework Version

.NET 7, .NET 6, .NET 5, .NET Core v3 and earlier, .NET Framework 4.x

Tags

ZIP

Additional context

No response