search

icsharpcode / SharpZipLib

#ziplib is a Zip, GZip, Tar and BZip2 library written entirely in C# for the .NET platform.
http://icsharpcode.github.io/SharpZipLib/
MIT License
3.7k stars 976 forks source link

Add net462 targeting #872

Open lahma opened 1 month ago

lahma commented 1 month ago

It's not that much of a maintenance burden and will remove some compatibility issues for folks still on full framework. SharpZipLib 2.0 could drop support if deemed so.

Also had to update testing dependencies to get NET 8 support.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

fixes #853 fixes #863

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.62%. Comparing base (c51ef18) to head (2255a47). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #872 +/- ## ========================================== - Coverage 74.78% 74.62% -0.16% ========================================== Files 72 75 +3 Lines 8535 8572 +37 ========================================== + Hits 6383 6397 +14 - Misses 2152 2175 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lahma commented 1 month ago

@piksel can you please take a look, this PR should fix GH Actions pipelines and adds the requested net462 target which should be quite safe addition.