icsharpcode / WpfDesigner

The WPF Designer from SharpDevelop
MIT License
949 stars 251 forks source link

Removed code that toggles selection when controls are placed #25

Closed awraae closed 7 years ago

awraae commented 7 years ago

In DefaultPlacementBehavior - when ending a placement - the selection is first cleared, and then right after set back to the previously selected controls.

It does not seem correct that the selection is modified based on a placement. Also it can cause performance issues for extensions that are used to edit a control over a number of placement operations because the extension is removed and reapplied on every operation.

I suggest this code is removed.

If this is a trick to reapply extensions for the selected controls I think it should be handled in a way where the selection is not altered.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the WPF Designer open source product (the "Contribution"). My Contribution is licensed under the MIT License.