search

icsm-au / DynAdjust

Least squares adjustment software
Apache License 2.0
72 stars 36 forks source link

N-Stat sorting improvement for Type X measures (and others?) #207

Open jhaasdyk-au opened 1 year ago

jhaasdyk-au commented 1 year ago

Brief description Sorting by N-stat appears to only consider the first triplet of a TypeX msr. If a high N-stat value appear further down a Type X msr group, the entire Type X msr is reported too far down the sorted N-Stat list. Feature improvement request: Consider N-stat value of all measurement components when sorting. (all measurement types).

image

Basic requirements N-Stat sorting to account for all measurement components, for all measurement types.

Priority Priority 2 (medium)] / Priority 3 (low)

nicgowans commented 1 year ago

Placing this example in support of the above. Note two highlighted nstats within the X-cluster msr which have absolute values larger than the max nstat of several earlier measurements.

nstat-bad-sort

jhaasdyk-au commented 1 week ago

In preparation for testing a new release candidate, I confirm here for current release v1.2.7

  1. --sort-adj-msr-field 7 (sort by Nstat) The issue described above persists: Sort order is as expected for all msr types here tested (DEHGXY) Undesirable: Xmsr sort only on the first triplet in the msr

  2. --sort-adj-msr-field 6 (sort by Adjusted std dev) (tested on request) Sort order is as expected for all msr types here tested (DEHGXY) Dmsr (all angular msr?) sort as a separate section at the bottom of the list (due to nature of msr quantity) Xmsr sort in the correct fashion (this was unexpected, given (1) above) Undesirable: Dmsr do not all sort as expected image image image

  3. --sort-adj-msr-field 5 (sort by Measurement Correction) (tested on request) Undesirable: Sort order is not as expected. Sorting criteria are not obvious across several msr types image image

jhaasdyk-au commented 1 week ago

Testing of v.1.2.8-rc5 indicates that the above issues are all RESOLVED.

  1. --sort-adj-msr-field 7 (sort by Nstat) Sort order is as expected for all msr types here tested (DEHGXY). Xmsr now sort as expected. image Sort order is as expected for all msr types here tested (DEHGXY).

  2. --sort-adj-msr-field 6 (sort by Adjusted std dev) Sort order is as expected for all msr types here tested (DEHGXY). Dmsr now sort as expected Note: Dmsr (all angular msr?) sort as a separate section at the bottom of the list image image

  3. --sort-adj-msr-field 5 (sort by Measurement Correction) Sort order is as expected for all msr types here tested (DEHGXY). Note: Dmsr (all angular msr?) sort as a separate section at the bottom of the list image image