search

icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
58 stars 73 forks source link

fix: enable scroll-y #1018

Closed KevinWu098 closed 2 weeks ago

KevinWu098 commented 2 weeks ago

Summary

  1. Changes in #1001 broke vertical scrolling on Dekstop
  2. This PR fixes those problems

Test Plan

  1. AA's desktop panels (left, right) should scroll appropriately on smaller view heights

chrome-capture-2024-10-3

ap0nia commented 2 weeks ago

My bad; I got skill checked 😔

It looks like it has to be anything besides the literal number 0. https://mui.com/system/sizing/#supported-values

adcockdalton commented 2 weeks ago

Scrolling is more laggy on this deployment than on the main page--is that a consequence of staging?

adcockdalton commented 2 weeks ago

After reviewing I think I'm just going to merge it, we can discuss optimization later we just need the scroll to work atm