icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
58 stars 73 forks source link

968 create error page #1035

Open alexespejo opened 2 days ago

alexespejo commented 2 days ago

Summary

Created a custom error page that displays when a user encounters an error or enters a bad route

Issues

In dark mode the link text color poorly contrasts the gray background

Test plan

This error page should appear when the user:

alexespejo commented 1 day ago

Edited message (dark and light)

image image
alexespejo commented 1 day ago

Also, can you add reproduction information in the description so that reviewer(s) don't have to figure out a way to induce an error? That should be under a section titled "Test Plan". See this PR as an example for writing a PR description Also, please specify which issue it closes there? I know it's in the title, but putting it in the description closes it automatically when the PR merges

Is there a known way to reproduce runtime errors like a bad fetch request. In theory the page should appear for all errors but I wanted to see

KevinWu098 commented 1 day ago

Also, can you add reproduction information in the description so that reviewer(s) don't have to figure out a way to induce an error? That should be under a section titled "Test Plan". See this PR as an example for writing a PR description Also, please specify which issue it closes there? I know it's in the title, but putting it in the description closes it automatically when the PR merges

Is there a known way to reproduce runtime errors like a bad fetch request. In theory the page should appear for all errors but I wanted to see

mm, might be a StackOverflow question -- one thing that jumps to mind is just writing in a throw Error into any given file!

MinhxNguyen7 commented 1 day ago

Is there a known way to reproduce runtime errors like a bad fetch request. In theory the page should appear for all errors but I wanted to see

Ah I didn't realize you hadn't figured that.

alexespejo commented 1 day ago

Also, can you add reproduction information in the description so that reviewer(s) don't have to figure out a way to induce an error? That should be under a section titled "Test Plan". See this PR as an example for writing a PR description Also, please specify which issue it closes there? I know it's in the title, but putting it in the description closes it automatically when the PR merges

Is there a known way to reproduce runtime errors like a bad fetch request. In theory the page should appear for all errors but I wanted to see

mm, might be a StackOverflow question -- one thing that jumps to mind is just writing in a throw Error into any given file!

this works